Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

fixed bug where no imageurl is passed, and also #70 #154

Merged
merged 2 commits into from Mar 20, 2018

Conversation

ShayanJavadi
Copy link
Contributor

@ShayanJavadi ShayanJavadi commented Mar 19, 2018

This fixes the lib throwing an error for panHandlers and originSizeKb when no imageUrls are passed.

it also removes a unused style object from the Y axis animated view

it also fixes #70 by adding a wrapper around the footer element that ensures that it says at the bottom. I added a prop called footerContainerStylewhich lets you change the style of this new wrapper.

here's the fix for renderFooter in action:
screen shot 2018-03-19 at 4 49 35 pm

@ShayanJavadi ShayanJavadi changed the title fixed bug where no imageurl is passed fixed bug where no imageurl is passed, and also #70 Mar 19, 2018

return (
<Animated.View
style={{ zIndex: 9999 }}
{...this.state.panResponderY.panHandlers}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is added by #153 , and i'll to restructure it, you just delete it, this is just right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t delete the line. I’m checking if panResponderY for undefined so no error gets thrown :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, i'm sorry to misread it.

@ascoders
Copy link
Owner

Thank you so mush, but it a bit conflict with #153, and i wll restructure it.

@ascoders ascoders merged commit f46f0e8 into ascoders:master Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renderFooter example
2 participants