Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where no imageurl is passed, and also #70 #154

Merged
merged 2 commits into from Mar 20, 2018

Conversation

@ShayanJavadi
Copy link
Contributor

@ShayanJavadi ShayanJavadi commented Mar 19, 2018

This fixes the lib throwing an error for panHandlers and originSizeKb when no imageUrls are passed.

it also removes a unused style object from the Y axis animated view

it also fixes #70 by adding a wrapper around the footer element that ensures that it says at the bottom. I added a prop called footerContainerStylewhich lets you change the style of this new wrapper.

here's the fix for renderFooter in action:
screen shot 2018-03-19 at 4 49 35 pm

@ShayanJavadi ShayanJavadi changed the title fixed bug where no imageurl is passed fixed bug where no imageurl is passed, and also #70 Mar 19, 2018

return (
<Animated.View
style={{ zIndex: 9999 }}
{...this.state.panResponderY.panHandlers}

This comment has been minimized.

@ascoders

ascoders Mar 20, 2018
Owner

This line is added by #153 , and i'll to restructure it, you just delete it, this is just right.

This comment has been minimized.

@ShayanJavadi

ShayanJavadi Mar 20, 2018
Author Contributor

I didn’t delete the line. I’m checking if panResponderY for undefined so no error gets thrown :)

This comment has been minimized.

@ascoders

ascoders Mar 20, 2018
Owner

Well, i'm sorry to misread it.

@ascoders
Copy link
Owner

@ascoders ascoders commented Mar 20, 2018

Thank you so mush, but it a bit conflict with #153, and i wll restructure it.

@ascoders ascoders merged commit f46f0e8 into ascoders:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants