fixed bug where no imageurl is passed, and also #70 #154
Conversation
…r. updated docs to reflect changes
ShayanJavadi
changed the title
|
|
||
| return ( | ||
| <Animated.View | ||
| style={{ zIndex: 9999 }} | ||
| {...this.state.panResponderY.panHandlers} |
ascoders
Mar 20, 2018
Owner
This line is added by #153 , and i'll to restructure it, you just delete it, this is just right.
This line is added by #153 , and i'll to restructure it, you just delete it, this is just right.
ShayanJavadi
Mar 20, 2018
Author
Contributor
I didn’t delete the line. I’m checking if panResponderY for undefined so no error gets thrown :)
I didn’t delete the line. I’m checking if panResponderY for undefined so no error gets thrown :)
ascoders
Mar 20, 2018
Owner
Well, i'm sorry to misread it.
Well, i'm sorry to misread it.
|
Thank you so mush, but it a bit conflict with #153, and i wll restructure it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes the lib throwing an error for panHandlers and originSizeKb when no imageUrls are passed.
it also removes a unused style object from the Y axis animated view
it also fixes #70 by adding a wrapper around the footer element that ensures that it says at the bottom. I added a prop called
footerContainerStylewhich lets you change the style of this new wrapper.here's the fix for renderFooter in action:
