Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AppInsights logging #115

Merged
merged 8 commits into from
Jan 2, 2019
Merged

Improve AppInsights logging #115

merged 8 commits into from
Jan 2, 2019

Conversation

c-w
Copy link
Member

@c-w c-w commented Jan 2, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #115 into master will decrease coverage by 0.05%.
The diff coverage is 84.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   91.37%   91.31%   -0.06%     
==========================================
  Files          21       21              
  Lines         858      887      +29     
==========================================
+ Hits          784      810      +26     
- Misses         74       77       +3
Impacted Files Coverage Δ
opwen_email_server/constants/logging.py 100% <ø> (ø) ⬆️
opwen_email_server/services/sendgrid.py 77.41% <0%> (ø) ⬆️
opwen_email_server/utils/collections.py 100% <100%> (ø) ⬆️
opwen_email_server/utils/log.py 88.23% <84.74%> (ø) ⬆️
opwen_email_server/actions.py 95.93% <96.15%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5706e01...a37ca66. Read the comment docs.

@c-w c-w merged commit 855f9dd into master Jan 2, 2019
@c-w c-w deleted the appinsights branch January 2, 2019 20:13
c-w added a commit that referenced this pull request Apr 28, 2020
Resolves https://github.com/ascoderu/opwen-webapp/issues/93

* Switch to direct AppConfig references

* Fix trailing character

* Add settings entry to update OPWEN_SIM_TYPE

* Add production-like server make recipe

* Ensure wvdial is always available

* Ensure state directory gets set from dotenv

* Remove unused import

* Ensure default wvdial config gets created

* Make script names consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants