Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 91.67% 91.71% +0.03%
==========================================
Files 22 22
Lines 925 929 +4
==========================================
+ Hits 848 852 +4
Misses 77 77
Continue to review full report at Codecov.
|
c-w
added a commit
that referenced
this pull request
Apr 28, 2020
* Generate usb_modeswitch config in-app * Optimize imports * Ensure wvdial path references are consistent * Avoid mutating any class-level variables * Extract shared modem config creation method * Make string formatting consistent * Ensure webapp can call wvdial and pppd * Update wvdial config for Hologram * Improve exception messages * Generate wvdial config if required * Move grep subshell to Python * Avoid double newlines in modeswitch conf * Move sim/modem data to own packages * Encapsulate wvdial integration * Encapsulate usb_modeswitch integration * Test for wvdial crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/ascoderu/opwen-webapp/issues/103