Merged
Conversation
c-w
added a commit
that referenced
this pull request
Apr 28, 2020
* Add wiring for attachments transfer file * Key emails off of uid * Add option to get_or_create by primary key * Add meaningful primary key for attachment * Add from_dict method for attachments * Make attachment uid non-private * Remove unused pkey argument * Add to_dict method for attachments * Restore kwargs style for get_or_create * Optimize get call by querying directly via key * Make potential N+1 queries more explicit * Add tests for stand-alone attachment creation * Add tests for more complex attachment scenarios * Add tests for sync with attachments * Simplify model instantiation * Inline excluded fields check * Ensure internal attachment uid is not uploaded * Avoid having to seek backwards on archive * Simplify attachment downloading * Fix sqlalchemy multi-thread object access error * Ensure attachments are ready after emails * Early-out in email body rendering * Correctly deserialize standalone attachments * Add sample email with external attachment * Add tests for get_attachment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.