Merged
Conversation
c-w
added a commit
that referenced
this pull request
Apr 28, 2020
* Fix test name * Make wvdial log persistent * Add prepare-release recipe to create sdist * Reboot device to ensure all permissions propagate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flower pod is currently crashing with the following error:
This is because k8s auto-injects a variable of the form
{deployment_name}_PORTwhich mistakenly gets read by flower:FLOWER_PORT=tcp://10.0.75.166:8080. Namespacing all the k8s objects with the release name should fix this issue.