Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index emails for portable mailbox view #241

Merged
merged 1 commit into from Oct 27, 2019
Merged

Index emails for portable mailbox view #241

merged 1 commit into from Oct 27, 2019

Conversation

c-w
Copy link
Member

@c-w c-w commented Oct 27, 2019

In https://github.com/ascoderu/opwen-webapp/issues/13, we aim to implement a deployment of the Lokole email application that enables users to access their emails "on the go" from any computer with email access. To implement this, we need to be able to query a users's received and sent emails. Currently we only store a flat listing of emails by their ids which is impossible to query efficiently.

This change creates an additional storage of the emails in a per-user folder structure which enables us to quickly look up all the emails a user has received or sent from Lokole which unblocks a future cloud-based implementation of EmailStore.

@c-w c-w requested a review from laura-barluzzi Oct 27, 2019
@codecov-io
Copy link

codecov-io commented Oct 27, 2019

Codecov Report

Merging #241 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   98.53%   98.58%   +0.04%     
==========================================
  Files          14       14              
  Lines         955      987      +32     
==========================================
+ Hits          941      973      +32     
  Misses         14       14
Impacted Files Coverage Δ
opwen_email_server/utils/email_parser.py 94.96% <100%> (ø) ⬆️
opwen_email_server/actions.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3cfd43...2a715f0. Read the comment docs.

@c-w c-w force-pushed the portable-emails branch 2 times, most recently from 2115102 to 13a5b1e Compare Oct 27, 2019
@c-w c-w merged commit 81b7d5c into master Oct 27, 2019
3 checks passed
@c-w c-w deleted the portable-emails branch Oct 27, 2019
c-w added a commit that referenced this issue Apr 28, 2020
* Make attribute access default value safer

* Slim down UserStore interface

* Add config to configure IoC container

* Make IoC parts more easily over-ridable
@nzola nzola mentioned this pull request Apr 29, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants