Enable authentication via Github access token #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint that registers new Lokole clients is currently protected via HTTP basic auth in client-register.yaml and the username and password is configured via a secret in Kubernetes. As we're onboarding new organizations that will deploy Lokole devices, we need an easier way to add and remove people who're authorized to authenticate with the API.
This pull request adds support for authenticating with the registration endpoint via Github identity. The process for enabling a user to authenticate is as follows:
read:org
scope.<github-user-name>:<personal-access-token>
as the value of the registration credential argument to the install.py script to set up new Lokole devices.Resolves #245