Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure kubeval runs on helm template output

Merged
merged 1 commit into from Feb 4, 2020
Merged

Ensure kubeval runs on helm template output #317

merged 1 commit into from Feb 4, 2020

Conversation

c-w
Copy link
Member

@c-w c-w commented Feb 4, 2020

I noticed in one of the CI logs a warning from kubeval mentioning an empty document:

Screenshot showing kubeval warning

It appears that kubeval in the current setup expects a single k8s yaml file so we can instruct helm to generate that instead of a directory which then logs the linting results as expected:

Screenshot showing kubeval linting results

See #246

@c-w c-w requested a review from mtotowamkwe Feb 4, 2020
@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          14       14           
  Lines        1206     1206           
=======================================
  Hits         1191     1191           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed1a11...a13479f. Read the comment docs.

@c-w c-w merged commit 63236a8 into master Feb 4, 2020
3 checks passed
@c-w c-w deleted the kubeval branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants