Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reply-all consider recipients of email #501

Merged
merged 1 commit into from Oct 8, 2020
Merged

Make reply-all consider recipients of email #501

merged 1 commit into from Oct 8, 2020

Conversation

c-w
Copy link
Member

@c-w c-w commented Oct 4, 2020

When replying-all to an email, previously recipients of the replied email weren't being added to the new email. This pull request changes this behavior by adding all people who were on the TO or CC line of the replied email to the CC line of the new email.

Fixes #449

@c-w c-w requested a review from sbathgate Oct 4, 2020
Copy link
Member

@sbathgate sbathgate left a comment

LGTM, using the chain itertool and list comprehension was a slick way to iterate through it. Only edge case I can think of is if someone unnecessarily adds someone to the To: and CC: fields but that is a pretty minimal consequence.

I feel like it would be worth adding a test to validate this expanded capability operates as expected too, no?

@c-w
Copy link
Member Author

c-w commented Oct 6, 2020

Currently we have no tests at all set up for this unfortunately, so I'd err on the side of deferring this to the larger effort in #418.

@c-w c-w merged commit c5a0c97 into master Oct 8, 2020
1 check passed
@c-w c-w deleted the reply-all branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReplyAll button doesn't work
2 participants