Conversation
sbathgate
approved these changes
Oct 6, 2020
Member
sbathgate
left a comment
sbathgate
left a comment
There was a problem hiding this comment.
LGTM, using the chain itertool and list comprehension was a slick way to iterate through it. Only edge case I can think of is if someone unnecessarily adds someone to the To: and CC: fields but that is a pretty minimal consequence.
I feel like it would be worth adding a test to validate this expanded capability operates as expected too, no?
Member
Author
|
Currently we have no tests at all set up for this unfortunately, so I'd err on the side of deferring this to the larger effort in #418. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When replying-all to an email, previously recipients of the replied email weren't being added to the new email. This pull request changes this behavior by adding all people who were on the TO or CC line of the replied email to the CC line of the new email.
Fixes #449