Conversation
While we do expose the PORT in an environment variable, this is more to make the value accessible to scripts rather than to enable configuration: we have other services (nginx) that depend on the API always listening on port 80, so really we should never expose another port than 80.
c-w
added a commit
that referenced
this pull request
Apr 28, 2020
* Add option to promote users to admins * Always use non-abbreviated admin wording in UI * Ensure to only promote non-admins * Move password generation logic into model * Ensure template and view validation matches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we do expose the PORT in an environment variable, this is more to
make the value accessible to scripts rather than to enable
configuration: we have other services (nginx) that depend on the API
always listening on port 80, so really we should never expose another
port than 80.