Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exposed port fixed #74

Merged
merged 1 commit into from Oct 3, 2018
Merged

Make exposed port fixed #74

merged 1 commit into from Oct 3, 2018

Conversation

c-w
Copy link
Member

@c-w c-w commented Oct 3, 2018

While we do expose the PORT in an environment variable, this is more to
make the value accessible to scripts rather than to enable
configuration: we have other services (nginx) that depend on the API
always listening on port 80, so really we should never expose another
port than 80.

While we do expose the PORT in an environment variable, this is more to
make the value accessible to scripts rather than to enable
configuration: we have other services (nginx) that depend on the API
always listening on port 80, so really we should never expose another
port than 80.
@c-w c-w merged commit 69800d0 into master Oct 3, 2018
1 of 3 checks passed
@c-w c-w deleted the fix-port branch Oct 3, 2018
c-w added a commit that referenced this issue Apr 28, 2020
* Add option to promote users to admins

* Always use non-abbreviated admin wording in UI

* Ensure to only promote non-admins

* Move password generation logic into model

* Ensure template and view validation matches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant