Add documentation for running with prod secrets #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @adamsclafani |
This change adds a new docker-compose file that can be used to override the local settings and switch to production mode (using blob storage and service bus). In order to make the override work, it was necessary to also rename the `CELERY_BROKER_URL` environment variable since it seems like the celery framework gives it special meaning and overrides any local configuration if the environment variable is set (thus the `CELERY_BROKER` value in `config.py` wasn't being used and rabbitmq was still used even with the production settings override). Changing the environment variable name to `QUEUE_BROKER_URL` fixes this behavior. For consistency with the above environment variable name change, other environment variables were also renamed to a more generic form (e.g. `CELERY_WORKERS` to `QUEUE_WORKERS` and `GUNICORN_WORKERS` to `SERVER_WORKERS`). See #75
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 88.46% 88.35% -0.11%
==========================================
Files 21 21
Lines 728 730 +2
==========================================
+ Hits 644 645 +1
- Misses 84 85 +1
Continue to review full report at Codecov.
|
c-w
added a commit
that referenced
this pull request
Apr 28, 2020
* Refactor to simpler devserver command * Inline devserver command * Add option to create admin during Lokole setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This change adds a new docker-compose file that can be used to override
the local settings and switch to production mode (using blob storage and
service bus).
In order to make the override work, it was necessary to also rename the
CELERY_BROKER_URLenvironment variable since it seems like the celeryframework gives it special meaning and overrides any local configuration
if the environment variable is set (thus the
CELERY_BROKERvalue inconfig.pywasn't being used and rabbitmq was still used even with theproduction settings override). Changing the environment variable name to
QUEUE_BROKER_URLfixes this behavior.For consistency with the above environment variable name change, other
environment variables were also renamed to a more generic form (e.g.
CELERY_WORKERStoQUEUE_WORKERSandGUNICORN_WORKERStoSERVER_WORKERS).See #75