Skip to content

Conversation

@c-w
Copy link
Member

@c-w c-w commented Nov 21, 2018

Resolves #59

Also:

  • Move services to single file

  • Refactor actions to dependency injection pattern

  • Increase test coverage

  • Ensure that paths can be resolved

  • Fix Connexion swagger UI

  • Fix celery command

  • Move to white-list for dockerignore

  • Update prod dependencies

  • Fix IDEA shell inspections

  • Exclude integration code from coverage report

@c-w c-w force-pushed the refactor-to-dependency-injection branch from 9ec945f to 0dd3383 Compare November 21, 2018 03:26
@codecov-io
Copy link

codecov-io commented Nov 21, 2018

Codecov Report

Merging #85 into master will increase coverage by 5.02%.
The diff coverage is 94.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   88.38%   93.41%   +5.02%     
==========================================
  Files          21       14       -7     
  Lines         732      668      -64     
==========================================
- Hits          647      624      -23     
+ Misses         85       44      -41
Impacted Files Coverage Δ
opwen_email_server/constants/events.py 100% <ø> (ø)
opwen_email_server/services/sendgrid.py 80.72% <ø> (+14.7%) ⬆️
opwen_email_server/constants/azure.py 100% <ø> (ø)
opwen_email_server/constants/queues.py 0% <0%> (ø)
opwen_email_server/utils/serialization.py 100% <100%> (ø) ⬆️
opwen_email_server/services/storage.py 97.74% <100%> (+0.16%) ⬆️
opwen_email_server/actions.py 96.32% <96.32%> (ø)
opwen_email_server/utils/email_parser.py 93.66% <0%> (-0.71%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668c58d...87a0556. Read the comment docs.

@c-w c-w merged commit 4251d28 into master Nov 21, 2018
@c-w c-w deleted the refactor-to-dependency-injection branch November 21, 2018 03:39
c-w pushed a commit that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor API classes to use dependency injection pattern

3 participants