Skip to content

Add registration endpoint#86

Merged
c-w merged 12 commits intomasterfrom
registration-endpoint
Nov 25, 2018
Merged

Add registration endpoint#86
c-w merged 12 commits intomasterfrom
registration-endpoint

Conversation

@c-w
Copy link
Copy Markdown
Member

@c-w c-w commented Nov 25, 2018

Resolves #64

Resolves #75

@c-w
Copy link
Copy Markdown
Member Author

c-w commented Nov 25, 2018

@adamsclafani You may want to have a look at this change to the Celery configuration that I applied to make to run the pipeline end-to-end in Docker: https://github.com/ascoderu/opwen-cloudserver/pull/86/files#diff-4e42e46a683445dbbd13479c1d2ac43f. For some reason, the task routes now seems to require a string as key (fully qualified path to the task function).

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 25, 2018

Codecov Report

Merging #86 into master will increase coverage by 0.16%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   93.41%   93.58%   +0.16%     
==========================================
  Files          14       14              
  Lines         668      701      +33     
==========================================
+ Hits          624      656      +32     
- Misses         44       45       +1
Impacted Files Coverage Δ
opwen_email_server/constants/events.py 100% <100%> (ø) ⬆️
opwen_email_server/config.py 94.73% <100%> (+0.98%) ⬆️
opwen_email_server/services/sendgrid.py 80.72% <100%> (ø) ⬆️
opwen_email_server/utils/log.py 87.71% <100%> (+0.44%) ⬆️
opwen_email_server/services/storage.py 97.85% <88.23%> (+0.11%) ⬆️
opwen_email_server/actions.py 96.15% <95%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4251d28...58c27d5. Read the comment docs.

@c-w c-w merged commit 3d20013 into master Nov 25, 2018
@c-w c-w deleted the registration-endpoint branch November 25, 2018 22:03
c-w added a commit that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants