Skip to content

Add final type annotations#88

Merged
c-w merged 6 commits intomasterfrom
final-type-annotations
Nov 26, 2018
Merged

Add final type annotations#88
c-w merged 6 commits intomasterfrom
final-type-annotations

Conversation

@c-w
Copy link
Member

@c-w c-w commented Nov 25, 2018

Resolves #79

@codecov-io
Copy link

codecov-io commented Nov 25, 2018

Codecov Report

Merging #88 into master will decrease coverage by 0.17%.
The diff coverage is 86.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #88      +/-   ##
=========================================
- Coverage   93.58%   93.4%   -0.18%     
=========================================
  Files          14      16       +2     
  Lines         701     728      +27     
=========================================
+ Hits          656     680      +24     
- Misses         45      48       +3
Impacted Files Coverage Δ
opwen_email_server/constants/queues.py 0% <0%> (ø) ⬆️
opwen_email_server/services/auth.py 100% <100%> (ø) ⬆️
opwen_email_server/constants/cache.py 100% <100%> (ø)
opwen_email_server/constants/events.py 100% <100%> (ø) ⬆️
opwen_email_server/constants/logging.py 100% <100%> (ø)
opwen_email_server/utils/collections.py 100% <100%> (ø) ⬆️
opwen_email_server/constants/azure.py 100% <100%> (ø) ⬆️
opwen_email_server/utils/log.py 88.23% <84.21%> (+0.51%) ⬆️
opwen_email_server/services/storage.py 97.14% <0%> (-0.72%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4649c...806b0e8. Read the comment docs.

@c-w c-w force-pushed the final-type-annotations branch from 4688690 to 2adbc8e Compare November 25, 2018 23:53
@c-w c-w force-pushed the final-type-annotations branch from 8c1d69f to c5fe2ee Compare November 26, 2018 03:02
@c-w c-w force-pushed the final-type-annotations branch from 838be28 to c7a1570 Compare November 26, 2018 03:15
@c-w c-w merged commit 4f48ba0 into master Nov 26, 2018
@c-w c-w deleted the final-type-annotations branch November 26, 2018 03:22
c-w pushed a commit that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants