Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store objects internally in msgpack #118

Merged
merged 6 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 3, 2019

No description provided.

c-w added some commits Jan 3, 2019

Store objects internally in msgpack
This ensures that we store the emails in a sane format internally (i.e.
with attachment content bytes stored as bytes) and only serialize them
to the data transfer format (base64 encoded bytes) at the edges when
communicating with the clients.
@codecov-io

This comment has been minimized.

Copy link

commented Jan 3, 2019

Codecov Report

Merging #118 into master will increase coverage by 0.09%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   91.18%   91.28%   +0.09%     
==========================================
  Files          21       22       +1     
  Lines         885      929      +44     
==========================================
+ Hits          807      848      +41     
- Misses         78       81       +3
Impacted Files Coverage Δ
opwen_email_server/utils/email_parser.py 93.75% <100%> (-0.17%) ⬇️
opwen_email_server/utils/path.py 100% <100%> (ø)
opwen_email_server/utils/temporary.py 100% <100%> (ø) ⬆️
opwen_email_server/utils/serialization.py 96% <100%> (+1.26%) ⬆️
opwen_email_server/actions.py 95.33% <89.47%> (-0.65%) ⬇️
opwen_email_server/services/storage.py 95.83% <97.05%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc97f0...1679185. Read the comment docs.

@c-w c-w merged commit 0e5cd9c into master Jan 3, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the msgpack branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.