Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent non-lowercase client names #128

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Feb 4, 2019

We're using Azure storage blob containers under the hood to map clients to their state. Containers are created as lower-case so the client names should also be lower-case.

Prevent non-lowercase client names
We're using Azure storage blob containers under the hood to map clients
to their state. Containers are created as lower-case so the client names
should also be lower-case.

c-w added a commit to ascoderu/opwen-webapp that referenced this pull request Feb 4, 2019

@c-w c-w referenced this pull request Feb 4, 2019

Merged

Always lower-case client names #128

@codecov-io

This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

Merging #128 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   91.71%   91.75%   +0.04%     
==========================================
  Files          22       23       +1     
  Lines         929      934       +5     
==========================================
+ Hits          852      857       +5     
  Misses         77       77
Impacted Files Coverage Δ
opwen_email_server/utils/string.py 100% <100%> (ø)
opwen_email_server/actions.py 95.4% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbaae5...42cdedb. Read the comment docs.

@c-w c-w merged commit 919e233 into master Feb 4, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the lowercase-client branch Feb 4, 2019

c-w added a commit to ascoderu/opwen-webapp that referenced this pull request Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.