Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Azurite as the local storage layer #139

Merged
merged 2 commits into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Feb 28, 2019

This fixes an issue with volumes on Linux/MacOS that @adamsclafani reported.

It also makes the local development mode closer to production since we're now using the Azurite Azure Storage emulator instead of the file-system when running locally.

@c-w c-w requested a review from adamsclafani Feb 28, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 28, 2019

Codecov Report

Merging #139 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   92.79%   92.87%   +0.07%     
==========================================
  Files          23       23              
  Lines         930      940      +10     
==========================================
+ Hits          863      873      +10     
  Misses         67       67
Impacted Files Coverage Δ
opwen_email_server/utils/env.py 100% <100%> (ø) ⬆️
opwen_email_server/config.py 96.15% <100%> (+1.15%) ⬆️
opwen_email_server/services/storage.py 95.87% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3453a13...b2629d5. Read the comment docs.

@c-w c-w merged commit 07ae515 into master Feb 28, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the azurite branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.