Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable authentication via Github access token #247
The endpoint that registers new Lokole clients is currently protected via HTTP basic auth in client-register.yaml and the username and password is configured via a secret in Kubernetes. As we're onboarding new organizations that will deploy Lokole devices, we need an easier way to add and remove people who're authorized to authenticate with the API.
This pull request adds support for authenticating with the registration endpoint via Github identity. The process for enabling a user to authenticate is as follows:
@@ Coverage Diff @@ ## master #247 +/- ## ========================================== + Coverage 98.58% 98.64% +0.06% ========================================== Files 14 14 Lines 987 1036 +49 ========================================== + Hits 973 1022 +49 Misses 14 14