Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace azure-storage-blob with libcloud #47

Merged
merged 2 commits into from Sep 11, 2018

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Sep 9, 2018

@adamsclafani tagging you as a reviewer on this pull request since it's related to your Celery refactor. This pull request replaces the azure-storage-blob library with apache-libcloud such that we can replace the Azure-based storage with the file-system for local development.

@laura-barluzzi tagging you as a reviewer for general feedback.

@c-w c-w requested a review from adamsclafani Sep 9, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Sep 9, 2018

Codecov Report

Merging #47 into master will increase coverage by 0.37%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   91.44%   91.82%   +0.37%     
==========================================
  Files          24       24              
  Lines         830      844      +14     
==========================================
+ Hits          759      775      +16     
+ Misses         71       69       -2
Impacted Files Coverage Δ
opwen_email_server/config.py 100% <100%> (ø) ⬆️
opwen_email_server/utils/temporary.py 100% <100%> (ø) ⬆️
opwen_email_server/services/storage.py 97.5% <96.96%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f27df...db9300e. Read the comment docs.

@c-w c-w force-pushed the libcloud branch from a1f9979 to 6b67269 Sep 9, 2018

@c-w c-w force-pushed the libcloud branch from 6b67269 to db9300e Sep 9, 2018

@c-w c-w requested a review from laura-barluzzi Sep 9, 2018

@c-w c-w merged commit db74590 into master Sep 11, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the libcloud branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.