Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exposed port fixed #74

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
1 participant
@c-w
Copy link
Member

commented Oct 3, 2018

While we do expose the PORT in an environment variable, this is more to
make the value accessible to scripts rather than to enable
configuration: we have other services (nginx) that depend on the API
always listening on port 80, so really we should never expose another
port than 80.

Make exposed port fixed
While we do expose the PORT in an environment variable, this is more to
make the value accessible to scripts rather than to enable
configuration: we have other services (nginx) that depend on the API
always listening on port 80, so really we should never expose another
port than 80.

@c-w c-w merged commit 69800d0 into master Oct 3, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the fix-port branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.