Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for running with prod secrets #76

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Oct 4, 2018

This change adds a new docker-compose file that can be used to override
the local settings and switch to production mode (using blob storage and
service bus).

In order to make the override work, it was necessary to also rename the
CELERY_BROKER_URL environment variable since it seems like the celery
framework gives it special meaning and overrides any local configuration
if the environment variable is set (thus the CELERY_BROKER value in
config.py wasn't being used and rabbitmq was still used even with the
production settings override). Changing the environment variable name to
QUEUE_BROKER_URL fixes this behavior.

For consistency with the above environment variable name change, other
environment variables were also renamed to a more generic form (e.g.
CELERY_WORKERS to QUEUE_WORKERS and GUNICORN_WORKERS to
SERVER_WORKERS).

See #75

@c-w

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2018

Add documentation for running with prod secrets
This change adds a new docker-compose file that can be used to override
the local settings and switch to production mode (using blob storage and
service bus).

In order to make the override work, it was necessary to also rename the
`CELERY_BROKER_URL` environment variable since it seems like the celery
framework gives it special meaning and overrides any local configuration
if the environment variable is set (thus the `CELERY_BROKER` value in
`config.py` wasn't being used and rabbitmq was still used even with the
production settings override). Changing the environment variable name to
`QUEUE_BROKER_URL` fixes this behavior.

For consistency with the above environment variable name change, other
environment variables were also renamed to a more generic form (e.g.
`CELERY_WORKERS` to `QUEUE_WORKERS` and `GUNICORN_WORKERS` to
`SERVER_WORKERS`).

See #75

@c-w c-w force-pushed the document-secrets branch from 607a684 to e824891 Oct 4, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Oct 4, 2018

Codecov Report

Merging #76 into master will decrease coverage by 0.1%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   88.46%   88.35%   -0.11%     
==========================================
  Files          21       21              
  Lines         728      730       +2     
==========================================
+ Hits          644      645       +1     
- Misses         84       85       +1
Impacted Files Coverage Δ
opwen_email_server/services/tasks.py 76.47% <100%> (ø) ⬆️
opwen_email_server/config.py 93.75% <66.66%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69800d0...e824891. Read the comment docs.

@c-w c-w merged commit 17eed54 into master Oct 4, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the document-secrets branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.