Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration endpoint #86

Merged
merged 12 commits into from Nov 25, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Nov 25, 2018

Resolves #64

Resolves #75

@c-w

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2018

@adamsclafani You may want to have a look at this change to the Celery configuration that I applied to make to run the pipeline end-to-end in Docker: https://github.com/ascoderu/opwen-cloudserver/pull/86/files#diff-4e42e46a683445dbbd13479c1d2ac43f. For some reason, the task routes now seems to require a string as key (fully qualified path to the task function).

@codecov-io

This comment has been minimized.

Copy link

commented Nov 25, 2018

Codecov Report

Merging #86 into master will increase coverage by 0.16%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   93.41%   93.58%   +0.16%     
==========================================
  Files          14       14              
  Lines         668      701      +33     
==========================================
+ Hits          624      656      +32     
- Misses         44       45       +1
Impacted Files Coverage Δ
opwen_email_server/constants/events.py 100% <100%> (ø) ⬆️
opwen_email_server/config.py 94.73% <100%> (+0.98%) ⬆️
opwen_email_server/services/sendgrid.py 80.72% <100%> (ø) ⬆️
opwen_email_server/utils/log.py 87.71% <100%> (+0.44%) ⬆️
opwen_email_server/services/storage.py 97.85% <88.23%> (+0.11%) ⬆️
opwen_email_server/actions.py 96.15% <95%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4251d28...58c27d5. Read the comment docs.

@c-w c-w merged commit 3d20013 into master Nov 25, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the registration-endpoint branch Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.