Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add final type annotations #88

Merged
merged 6 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Nov 25, 2018

Resolves #79

@codecov-io

This comment has been minimized.

Copy link

commented Nov 25, 2018

Codecov Report

Merging #88 into master will decrease coverage by 0.17%.
The diff coverage is 86.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #88      +/-   ##
=========================================
- Coverage   93.58%   93.4%   -0.18%     
=========================================
  Files          14      16       +2     
  Lines         701     728      +27     
=========================================
+ Hits          656     680      +24     
- Misses         45      48       +3
Impacted Files Coverage Δ
opwen_email_server/constants/queues.py 0% <0%> (ø) ⬆️
opwen_email_server/services/auth.py 100% <100%> (ø) ⬆️
opwen_email_server/constants/cache.py 100% <100%> (ø)
opwen_email_server/constants/events.py 100% <100%> (ø) ⬆️
opwen_email_server/constants/logging.py 100% <100%> (ø)
opwen_email_server/utils/collections.py 100% <100%> (ø) ⬆️
opwen_email_server/constants/azure.py 100% <100%> (ø) ⬆️
opwen_email_server/utils/log.py 88.23% <84.21%> (+0.51%) ⬆️
opwen_email_server/services/storage.py 97.14% <0%> (-0.72%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4649c...806b0e8. Read the comment docs.

@c-w c-w force-pushed the final-type-annotations branch from 4688690 to 2adbc8e Nov 25, 2018

@c-w c-w force-pushed the final-type-annotations branch from 8c1d69f to c5fe2ee Nov 26, 2018

@c-w c-w force-pushed the final-type-annotations branch from 838be28 to c7a1570 Nov 26, 2018

@c-w c-w merged commit 4f48ba0 into master Nov 26, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the final-type-annotations branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.