Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up DNS integration module #89

Merged
merged 7 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Nov 26, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

commented Nov 26, 2018

Codecov Report

Merging #89 into master will decrease coverage by 2.72%.
The diff coverage is 44.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage    93.4%   90.68%   -2.73%     
==========================================
  Files          16       19       +3     
  Lines         728      762      +34     
==========================================
+ Hits          680      691      +11     
- Misses         48       71      +23
Impacted Files Coverage Δ
opwen_email_server/services/cloudflare.py 0% <0%> (ø)
opwen_email_server/constants/cloudflare.py 0% <0%> (ø)
opwen_email_server/constants/sendgrid.py 100% <100%> (ø)
opwen_email_server/actions.py 96.2% <100%> (+0.04%) ⬆️
opwen_email_server/services/sendgrid.py 77.41% <57.14%> (-3.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f48ba0...3a640dd. Read the comment docs.

@c-w c-w merged commit 23c2d3d into master Nov 26, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the refactor-dns branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.