Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render images that reference attachments #111

Merged
merged 3 commits into from Jan 6, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 6, 2019

Resolves #103.

This is based on #104.

Screenshot showing inline CID images being rendered

@c-w c-w requested a review from laura-barluzzi Jan 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 6, 2019

Codecov Report

Merging #111 into master will decrease coverage by 0.86%.
The diff coverage is 25.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   70.49%   69.62%   -0.87%     
==========================================
  Files          19       20       +1     
  Lines        1359     1386      +27     
==========================================
+ Hits          958      965       +7     
- Misses        401      421      +20
Impacted Files Coverage Δ
opwen_email_client/webapp/__init__.py 100% <100%> (ø) ⬆️
opwen_email_client/domain/email/sql_store.py 100% <100%> (ø) ⬆️
opwen_email_client/webapp/jinja.py 20% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a69ce...992a1ef. Read the comment docs.

@c-w c-w force-pushed the email-cid branch from 3254f31 to 992a1ef Jan 6, 2019

@c-w c-w changed the title Email cid Display inline images that reference an attachment Jan 6, 2019

@c-w c-w changed the title Display inline images that reference an attachment Render images that reference attachments Jan 6, 2019

@c-w c-w merged commit fb1c44a into master Jan 6, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the email-cid branch Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.