Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make check_call argument a string #123

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 23, 2019

According to the docs [1]:

If shell is True, it is recommended to pass args as a string rather than
as a sequence.

[1] https://docs.python.org/3/library/subprocess.html#subprocess.Popen

Make check_call argument a string
According to the docs [1]:

```
If shell is True, it is recommended to pass args as a string rather than
as a sequence.
```

[1] https://docs.python.org/3/library/subprocess.html#subprocess.Popen

@c-w c-w merged commit a83ef4a into master Jan 23, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@codecov-io

This comment has been minimized.

Copy link

commented Jan 23, 2019

Codecov Report

Merging #123 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   68.13%   68.16%   +0.02%     
==========================================
  Files          26       26              
  Lines        1494     1492       -2     
==========================================
- Hits         1018     1017       -1     
+ Misses        476      475       -1
Impacted Files Coverage Δ
opwen_email_client/domain/modem/__init__.py 36.84% <0%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f920763...5262019. Read the comment docs.

@c-w c-w deleted the check-call branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.