Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused JS variables #135

Merged
merged 3 commits into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Feb 18, 2019

Also: add eslint to prevent these errors in the future.

@c-w c-w force-pushed the remove-unused branch 7 times, most recently from 27736e8 to a7f1dcd Feb 19, 2019

c-w added some commits Feb 18, 2019

@c-w c-w force-pushed the remove-unused branch from a7f1dcd to e04bd01 Feb 19, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 19, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage    68.9%   69.41%   +0.51%     
==========================================
  Files          28       28              
  Lines        1537     1563      +26     
==========================================
+ Hits         1059     1085      +26     
  Misses        478      478
Impacted Files Coverage Δ
opwen_email_client/webapp/config.py 100% <0%> (ø) ⬆️
opwen_email_client/webapp/ioc.py 100% <0%> (ø) ⬆️
opwen_email_client/webapp/mkwvconf.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db1bea...0783f5b. Read the comment docs.

@c-w c-w force-pushed the remove-unused branch 4 times, most recently from 963de83 to 1a49ead Feb 19, 2019

@c-w c-w force-pushed the remove-unused branch from 1a49ead to 0783f5b Feb 19, 2019

@c-w c-w merged commit 7ae9689 into master Feb 19, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the remove-unused branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.