Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indicator for number of emails to be synced #171

Merged
merged 1 commit into from May 12, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented May 12, 2019

Resolves #170

See below for a screenshot of the new functionality: the admin can now see how many emails will be synced before executing the action.

Screenshot showing number of emails to be synced indicator

@codecov-io

This comment has been minimized.

Copy link

commented May 12, 2019

Codecov Report

Merging #171 into master will increase coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage    69.2%   69.27%   +0.06%     
==========================================
  Files          28       28              
  Lines        1682     1689       +7     
==========================================
+ Hits         1164     1170       +6     
- Misses        518      519       +1
Impacted Files Coverage Δ
opwen_email_client/webapp/views.py 46.04% <0%> (-0.17%) ⬇️
opwen_email_client/domain/email/store.py 97.1% <100%> (+0.08%) ⬆️
opwen_email_client/domain/email/sql_store.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9473baa...8179417. Read the comment docs.

@c-w c-w merged commit be3ff49 into master May 12, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the sync-indicator branch May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.