Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace crontab with celery periodic task #180

Merged
merged 10 commits into from May 15, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented May 14, 2019

Resolves #176

@codecov-io

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #180 into master will increase coverage by 0.61%.
The diff coverage is 41.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #180      +/-   ##
========================================
+ Coverage   69.38%    70%   +0.61%     
========================================
  Files          29     29              
  Lines        1695   1670      -25     
========================================
- Hits         1176   1169       -7     
+ Misses        519    501      -18
Impacted Files Coverage Δ
opwen_email_client/webapp/login.py 77.31% <ø> (+3.73%) ⬆️
opwen_email_client/webapp/views.py 47.21% <0%> (ø) ⬆️
opwen_email_client/webapp/forms/settings.py 42.18% <0%> (+4.09%) ⬆️
opwen_email_client/webapp/config.py 100% <100%> (ø) ⬆️
opwen_email_client/webapp/tasks.py 51.85% <50%> (-4.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4116c86...e8537ca. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #180 into master will increase coverage by 0.69%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   69.38%   70.07%   +0.69%     
==========================================
  Files          29       29              
  Lines        1695     1671      -24     
==========================================
- Hits         1176     1171       -5     
+ Misses        519      500      -19
Impacted Files Coverage Δ
opwen_email_client/webapp/login.py 77.31% <ø> (+3.73%) ⬆️
opwen_email_client/webapp/views.py 47.21% <0%> (ø) ⬆️
opwen_email_client/webapp/config.py 100% <100%> (ø) ⬆️
opwen_email_client/webapp/forms/settings.py 42.85% <16.66%> (+4.76%) ⬆️
opwen_email_client/webapp/tasks.py 50% <44.44%> (-6.53%) ⬇️
opwen_email_client/webapp/actions.py 37.7% <80%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4116c86...6e1f531. Read the comment docs.

@c-w c-w force-pushed the celery-crontab branch 3 times, most recently from 2f6a6c4 to 080c580 May 15, 2019

@c-w c-w force-pushed the celery-crontab branch 2 times, most recently from 29a0cb3 to 418c6e4 May 15, 2019

@c-w c-w force-pushed the celery-crontab branch from 418c6e4 to 78e0943 May 15, 2019

@c-w c-w merged commit da13b26 into master May 15, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@c-w c-w deleted the celery-crontab branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.