Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user export #227

Merged
merged 6 commits into from Nov 24, 2019
Merged

Implement user export #227

merged 6 commits into from Nov 24, 2019

Conversation

@c-w
Copy link
Member

c-w commented Nov 23, 2019

In #13 we need to synchronize users from each Lokole device to the server so that we can enable users to access their accounts from any internet connected device.

This pull request adds a file to the Lokole sync that lists all the usernames and hashed passwords of users who created an account since the last sync. Making this change required a fairly large refactor to encapsulate the flask-login module which is being used for user management.

@c-w c-w requested a review from laura-barluzzi Nov 23, 2019
@nzola nzola mentioned this pull request Nov 23, 2019
3 of 8 tasks complete
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #227 into master will decrease coverage by 0.68%.
The diff coverage is 61.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   69.56%   68.88%   -0.69%     
==========================================
  Files          28       31       +3     
  Lines        1712     1790      +78     
==========================================
+ Hits         1191     1233      +42     
- Misses        521      557      +36
Impacted Files Coverage Δ
opwen_email_client/webapp/tasks.py 46.66% <0%> (-3.34%) ⬇️
opwen_email_client/webapp/ioc.py 96.87% <100%> (+1.22%) ⬆️
opwen_email_client/domain/email/user_store.py 100% <100%> (ø)
opwen_email_client/webapp/config.py 100% <100%> (ø) ⬆️
opwen_email_client/webapp/forms/login.py 100% <100%> (ø)
opwen_email_client/webapp/actions.py 35.76% <25%> (-0.54%) ⬇️
opwen_email_client/domain/email/sync.py 90.78% <46.66%> (-5.32%) ⬇️
opwen_email_client/webapp/login.py 62.74% <57.4%> (-14.58%) ⬇️
opwen_email_client/webapp/views.py 46.59% <8.33%> (-1.24%) ⬇️
opwen_email_client/webapp/security.py 84.61% <84.61%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1407047...8b758bf. Read the comment docs.

@c-w c-w merged commit 52d9c0a into master Nov 24, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@c-w c-w deleted the export-users branch Nov 24, 2019
@c-w c-w mentioned this pull request Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.