From f6dd0b296c552185b155651f1f9e80f9e2c118a1 Mon Sep 17 00:00:00 2001
From: Ashley <73482956+ascopes@users.noreply.github.com>
Date: Wed, 23 Nov 2022 12:32:52 +0000
Subject: [PATCH 1/2] Enable manifold warning preprocessor test
Now that https://github.com/manifold-systems/manifold/issues/399 has been fixed,
this test should pass
---
.../acceptancetests/manifold/ManifoldPreprocessorTest.groovy | 2 --
1 file changed, 2 deletions(-)
diff --git a/acceptance-tests/acceptance-tests-manifold-systems/src/test/groovy/io/github/ascopes/acceptancetests/manifold/ManifoldPreprocessorTest.groovy b/acceptance-tests/acceptance-tests-manifold-systems/src/test/groovy/io/github/ascopes/acceptancetests/manifold/ManifoldPreprocessorTest.groovy
index 4645bb8ef..0db14e6ff 100644
--- a/acceptance-tests/acceptance-tests-manifold-systems/src/test/groovy/io/github/ascopes/acceptancetests/manifold/ManifoldPreprocessorTest.groovy
+++ b/acceptance-tests/acceptance-tests-manifold-systems/src/test/groovy/io/github/ascopes/acceptancetests/manifold/ManifoldPreprocessorTest.groovy
@@ -17,7 +17,6 @@ package io.github.ascopes.acceptancetests.manifold
import io.github.ascopes.jct.compilers.JctCompiler
import io.github.ascopes.jct.junit.JavacCompilerTest
-import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.DisplayName
import static io.github.ascopes.jct.assertions.JctAssertions.assertThatCompilation
@@ -84,7 +83,6 @@ class ManifoldPreprocessorTest {
assertThat(greeting).isEqualTo("Hello, World! (symbol was not defined)")
}
- @Disabled("See https://github.com/manifold-systems/manifold/issues/399")
@DisplayName("Warning directives produce compiler warnings in JCT")
@JavacCompilerTest(configurers = [ManifoldPluginConfigurer])
void warningDirectivesProduceCompilerWarningsInJct(JctCompiler compiler) {
From 7e4d1125998e907d425fe310549e665a8791e2d3 Mon Sep 17 00:00:00 2001
From: Ashley <73482956+ascopes@users.noreply.github.com>
Date: Wed, 23 Nov 2022 12:40:16 +0000
Subject: [PATCH 2/2] Update pom.xml
---
acceptance-tests/acceptance-tests-manifold-systems/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/acceptance-tests/acceptance-tests-manifold-systems/pom.xml b/acceptance-tests/acceptance-tests-manifold-systems/pom.xml
index bcac5ee9c..21ab3fa77 100644
--- a/acceptance-tests/acceptance-tests-manifold-systems/pom.xml
+++ b/acceptance-tests/acceptance-tests-manifold-systems/pom.xml
@@ -80,7 +80,7 @@
maven-surefire-plugin
- true
+ false