From c917db8513c2ea764edd2c3fc9d233a279ca51a8 Mon Sep 17 00:00:00 2001 From: Ashley Scopes <73482956+ascopes@users.noreply.github.com> Date: Sat, 21 Jan 2023 11:58:41 +0000 Subject: [PATCH] Remove -implicit flag from default compilation --- .../compilers/javac/JavacJctCompilerImpl.java | 1 - .../javac/JavacJctCompilerImplTest.java | 20 ++++++++++++++++--- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/java-compiler-testing/src/main/java/io/github/ascopes/jct/compilers/javac/JavacJctCompilerImpl.java b/java-compiler-testing/src/main/java/io/github/ascopes/jct/compilers/javac/JavacJctCompilerImpl.java index 2cbd04402..025d56efa 100644 --- a/java-compiler-testing/src/main/java/io/github/ascopes/jct/compilers/javac/JavacJctCompilerImpl.java +++ b/java-compiler-testing/src/main/java/io/github/ascopes/jct/compilers/javac/JavacJctCompilerImpl.java @@ -68,7 +68,6 @@ public JavacJctCompilerImpl(String name) { */ public JavacJctCompilerImpl(String name, JavaCompiler jsr199Compiler) { super(name, jsr199Compiler, new JavacJctFlagBuilderImpl()); - addCompilerOptions("-implicit:class"); } @Override diff --git a/java-compiler-testing/src/test/java/io/github/ascopes/jct/tests/unit/compilers/javac/JavacJctCompilerImplTest.java b/java-compiler-testing/src/test/java/io/github/ascopes/jct/tests/unit/compilers/javac/JavacJctCompilerImplTest.java index b84237b00..1783c91ef 100644 --- a/java-compiler-testing/src/test/java/io/github/ascopes/jct/tests/unit/compilers/javac/JavacJctCompilerImplTest.java +++ b/java-compiler-testing/src/test/java/io/github/ascopes/jct/tests/unit/compilers/javac/JavacJctCompilerImplTest.java @@ -89,11 +89,25 @@ void compilersHaveTheExpectedFlagBuilder() { assertThat(compiler.getFlagBuilder()).isInstanceOf(JavacJctFlagBuilderImpl.class); } - @DisplayName("compilers have the -implicit:class flag set") + @DisplayName("Compilers have no default compiler flags set") @Test - void compilersHaveTheImplicitClassFlagSet() { + void compilersHaveNoDefaultCompilerFlagsSet() { // Then - assertThat(compiler.getCompilerOptions()).contains("-implicit:class"); + assertThat(compiler.getCompilerOptions()).isEmpty(); + } + + @DisplayName("Compilers have no default annotation processor flags set") + @Test + void compilersHaveNoDefaultAnnotationProcessorFlagsSet() { + // Then + assertThat(compiler.getAnnotationProcessorOptions()).isEmpty(); + } + + @DisplayName("Compilers have no default annotation processors set") + @Test + void compilersHaveNoDefaultAnnotationProcessorsSet() { + // Then + assertThat(compiler.getAnnotationProcessors()).isEmpty(); } @DisplayName("compilers have the expected default release string")