Limit thumbnail size to 5mb #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diminator Changing this setting works like a charm. Made https://github.com/ascribe/spoolio/pull/34 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of AD-1530, it was realized that our current limit for user selectable thumbnails is 25GB. This PR sets a more sensible limit, but since we now support thumbnail generation for user selectable thumbnails, it wouldn't hurt to allow higher limits than 5MB.
@diminator @sbellem It seems like S3 rejects signature creation when the file limit is not set to 25GB, which makes these uploads fail.
You'll see that this request works:
But this one does not:
