Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #490

Conversation

lamby
Copy link
Contributor

@lamby lamby commented Apr 15, 2018

Whilst working on the Reproducible Builds effort [0], we noticed that asdf could not be built reproducibly.

This is due to it including nondeterminstically random output as well as the current build time in the documentation.

This was originally filed in Debian as #895737 [1].

[0] https://reproducible-builds.org/
[1] https://bugs.debian.org/895737

Signed-off-by: Chris Lamb lamby@debian.org

Whilst working on the Reproducible Builds effort [0], we noticed
that asdf could not be built reproducibly.

This is due to it including nondeterminstically random output as well
as the current build time in the documentation.

This was originally filed in Debian as #895737 [1].

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/895737

Signed-off-by: Chris Lamb <lamby@debian.org>
@stsci-bot
Copy link

stsci-bot bot commented Apr 15, 2018

Hi there @lamby 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 93.99% when pulling 286f349 on lamby:895737-python-asdf-please-make-the-build-reproducible into 0684792 on spacetelescope:master.

@drdavella
Copy link
Contributor

Thanks @lamby!

@drdavella drdavella merged commit 6dde499 into asdf-format:master Apr 16, 2018
@lamby lamby deleted the 895737-python-asdf-please-make-the-build-reproducible branch April 17, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants