Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lua API to access new UserData properties #88

Closed
Gasparoken opened this issue Dec 15, 2022 · 1 comment · Fixed by aseprite/aseprite#3648
Closed

Add Lua API to access new UserData properties #88

Gasparoken opened this issue Dec 15, 2022 · 1 comment · Fixed by aseprite/aseprite#3648
Assignees
@dacap
Labels
feature

Comments

@Gasparoken
Copy link
Member

Gasparoken commented Dec 15, 2022 •
edited by dacap
Loading

EDIT Just in case the following design was proposed by @dacap but there is no final API design, we have to talk about the best options.

Related to aseprite/aseprite#3625

Add Lua API to access doc::UserData properties, e.g.

myLayer.extraData["extension id"].extensionCustomProperty or
myLayer.properties["extension id"].extensionCustomProperty
myLayer.extensionData["extension id"].extensionCustomProperty or

and probably

myLayer.userData.myProperty or
myLayer.userProperties.myProperty

as shortcut for

myLayer.extraData[""].myProperty
...
@Gasparoken Gasparoken converted this from a draft issue Dec 15, 2022
@Gasparoken Gasparoken self-assigned this Dec 15, 2022
@dacap
Copy link
Member

dacap commented Dec 16, 2022

This depends on aseprite/aseprite#3631 and the API design must be discussed first.

@Gasparoken Gasparoken moved this from In Progress to Todo in Attachment System Dec 16, 2022
@Gasparoken Gasparoken moved this from Todo to In Progress in Attachment System Dec 20, 2022
@dacap dacap assigned dacap and unassigned Gasparoken Dec 29, 2022
dacap added a commit to dacap/aseprite that referenced this issue Dec 30, 2022
@dacap
[lua] Add access to user data properties in Sprite object (aseprite/a…
ae61143 
…pi#88)

This is a basic implementation where we can only access basic
properties (not maps or vectors yet).
@dacap dacap mentioned this issue Dec 30, 2022
Merged
@dacap dacap linked a pull request Dec 30, 2022 that will close this issue
Lua API for user/extensions properties aseprite/aseprite#3648
Merged
dacap added a commit to dacap/aseprite that referenced this issue Dec 30, 2022
@dacap
[lua] Add access to user data properties in Sprite object (aseprite/a…
30032aa 
…pi#88)

This is a basic implementation where we can only access basic
properties (not maps or vectors yet).
dacap added a commit to dacap/aseprite that referenced this issue Dec 30, 2022
@dacap
[lua] Add access to user data properties in Sprite object (aseprite/a…
fe52ce2 
…pi#88)

This is a basic implementation where we can only access basic
properties (not maps or vectors yet).
dacap added a commit to dacap/aseprite that referenced this issue Dec 30, 2022
@dacap
[lua] Add access to user data properties in Sprite object (aseprite/a…
ff10e36 
…pi#88)

This is a basic implementation where we can only access basic
properties (not maps or vectors yet).
dacap added a commit to dacap/aseprite that referenced this issue Jan 2, 2023
@dacap
[lua] Add access to user data properties in Sprite object (aseprite/a…
76a398b 
…pi#88)

This is a basic implementation where we can only access basic
properties (not maps or vectors yet).
@github-project-automation github-project-automation bot moved this from In Progress to Done in Attachment System Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dacap dacap

Labels
feature
Projects
Attachment System
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lua API for user/extensions properties dacap/aseprite
2 participants
@dacap @Gasparoken