Crash when º key is pressed in the app::SelectAccelerator dialog on Windows #1065

Closed
dacap opened this Issue Apr 14, 2016 · 3 comments

Comments

Projects
None yet
2 participants
Owner

dacap commented Apr 14, 2016

Maybe other (unicode) keys crashes the program. I didn't check other platforms yet.

@dacap dacap added this to the v1.1 milestone Apr 14, 2016

Owner

dacap commented Apr 18, 2016

(Highly probable that this crash was introduced with 27b5503 fix.)

@dacap dacap self-assigned this Apr 18, 2016

dacap added a commit that referenced this issue Apr 18, 2016

Make base::string_to_lower/upper() use tolower/upper() for each Unico…
…de char

It fixes issue #1065 because now UTF-8 strings are not destroyed by
these base::string_to_*() routines. This issue appears when we use
std::setlocale(), which was introduced in 27b5503

@dacap dacap closed this Apr 18, 2016

Collaborator

raetiacorvus commented Apr 18, 2016

With current master on linux i do not get a crash with unicodes but for some i am not really able to set them. I can enter them but they do not show up in the keyboard shortcuts after pressing ok in the accelerator add dialog. For example i can not use german umlaut characters ö ä ü. It should be also noted, that they show up when combing them with a modifier but do not trigger. This may be because for example alt+ö sends the character ;. Not sure if this is related to this bug or if i should open another one. Could also be that this will be solved with skia?

Owner

dacap commented Apr 18, 2016

Yeah, it's a known issue. Keyboard shortcuts with Unicode characters or special symbols aren't working as expected. I've a private branch that I've to bring back to master to continue. Anyway I want to finish the X11 Skia port first, remove Allegro back-end, and fix the keyboard. I'll write a task list in #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment