Unified color picker..? #1102

Closed
bodhiBit opened this Issue May 1, 2016 · 4 comments

Comments

Projects

Done in Next release

3 participants

bodhiBit commented May 1, 2016 edited

There seems to be two(ish) color picker windows in the app.. There's the one below the palette which you can use to add colors to the palette and then one to edit the colors already in the palette.. And I can only customize the first one to display as a colorwheel etc, which I really like, but most of the time I'm editing the colors I already have, so I can't use the colorwheel picker for that..

I don't really get why there has to be two different places to pick colors.. Why not just have one..? you can already expand the palette and copy colors around, so just have the main color picker edit the selected palette color instead of adding them..
Or maybe have the option to set the picker in either edit or add mode..

Owner

dacap commented May 2, 2016

Hi @bodhiBit, I always wanted to unify both color selectors. The most "intuitive" behavior I thought about, is that when the Palette Editor is visible/enable, color selector/picker edits colors instead of selecting colors/showing warning icon to add colors. In this way we can switch between those two modes (edit/add as you said).

bodhiBit commented May 2, 2016

I guess that could be a way to do it.. just seems a little redundant to have two color pickers (or up to four when you click the fore-/background colors below the wheel).. Is there any particular reason to have that many color pickers..?

dacap added this to the v1.2 milestone Jul 14, 2016

Owner

dacap commented Jul 14, 2016

Is there any particular reason to have that many color pickers..?

Just legacy design decisions.

I'll be discussing a possible UI design to create the unified color selector. The only thing I'm sure right now is that F4 ("Edit Palette") should change the mode in color selectors behaves. E.g. When the "Edit Palette" button isn't activated, color selectors should behave as they behave right now. When the "Edit Palette" is activated, color selectors should change palette colors.

The only problem is to unify RGB and HSB sliders/text entries in the same color-bar widget.

If we use any indexed-color picker, please allow us to use an HSL picker too. It's killing me to use HSB to do my indexed-color palettes, since I come from Gale and have always had access to the HSL slider in some form or another in all my other art/animation programs.

It's the one thing that's really hurting my color-picking sensibilities in ASEsprite, and it's not something I think I can easily get over when working steadily with indexed palettes as I usually do. :(

And regarding the color-bar widget, it's a simple fix:

You could simply have a Radio button list of pickers in the picker window that changes the entire window's interface between the RGB/HSB/HSL (<-- yes, HSL) various picker bars, depending on which is selected.

@dacap dacap added a commit that referenced this issue May 24, 2017

@dacap dacap Add Hue/Saturation filter (fix #1186)
Added new gfx::Hsl class to handle HSL color model(related to #707 and #1102)
239ac42

dacap referenced this issue May 26, 2017

Open

New color choosers/selectors #707

5 of 7 tasks complete

dacap self-assigned this Jun 21, 2017

dacap moved from Planned to In progress in Next release Jun 21, 2017

dacap closed this in 7d1404d Jun 22, 2017

dacap moved from In progress to Done in Next release Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment