Invalid Selection After Removing Frames + Undo Error Due to Invalid Selection #1235

Closed
KasumiArai opened this Issue Aug 17, 2016 · 1 comment

Comments

Projects
None yet
2 participants

KasumiArai commented Aug 17, 2016 edited

Describe your bug report or feature request here
(Edit: Greatly simplified steps after iterating different ways to try this)
Hah. This one took a bit to figure out. If you click and drag to select frames starting in a left to right motion (that is, selecting frames with a greater number than the one first clicked) and then reverse directions (that is, selecting frames with a smaller number than the one first clicked) while still holding the mouse button down, the selection will not be removed on delete. You can then delete again with an invalid range, and undoing sometimes resets the exposure time to 1ms (among other quirks.)

  1. Open Aseprite
  2. Open this gif:
    testframeselectiongif
  3. Click and drag starting at frame 8, mouse your mouse to frame 9. DO NOT RELEASE CLICK
  4. Move your mouse to frame 2.
  5. Release click.
  6. Remove frames. (Bug one, the selection stays active and is greater than the available frames.)
  7. Remove frames.
  8. Undo. (Bug two, the previous action is not properly undone. There are now empty cels.)
  9. Undo again. (Continuation of bug two. The animation now has 15 frames instead of 9. Frame 9 now has 1ms delay instead of 200)
    frameselectionerror3

(It occasionally leaves the selection when selecting right to left without starting to go left to right first. I cannot get this happen to consistently, but I'm noting it to look out for while looking into the code)

Aseprite and System version

Aseprite v1.2-beta1-Steam on Windows Vista 32bit

dacap added this to the v1.2 milestone Aug 17, 2016

Owner

dacap commented Aug 17, 2016

Thanks for this bug report @KasumiArai, I'm just modifying these operations for v1.2 (with layers groups). I think it will need a special patch for v1.1 anyway.

@dacap dacap modified the milestone: v1.1, v1.2 Aug 17, 2016

dacap self-assigned this Aug 17, 2016

dacap closed this in 0f2d0cb Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment