Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Color dialog preview is crazy slow #1400

oxysoft opened this issue Jan 29, 2017 · 4 comments

Replace Color dialog preview is crazy slow #1400

oxysoft opened this issue Jan 29, 2017 · 4 comments


Copy link

@oxysoft oxysoft commented Jan 29, 2017

The preview when changing to another color in the Replace Color dialog is mind bogglingly slow compared to the fill bucket for example, which is almost instant. See for yourself in this webm

Aseprite and System version

  • Aseprite version: v1.1.11-trial
  • System: Windows 10
Copy link

@KasumiArai KasumiArai commented Jan 30, 2017

Probably because the fill bucket is destructive and that preview is non destructive. i.e. using that preview won't eliminate your redo buffer, but using the fill bucket will.

It's doing it line by line in the preview so as not to use a lot of memory while not actually changing the image itself. If you hit OK (or pressed enter), the preview generation would be interrupted and the change would be instant (or at least not very slow) just like the fill tool because OK commits to an actual change rather than a preview of one.

Shorter: You'd basically need two copies of the image in memory to non destructively preview at the same speed. Or I guess a second undo stack which could be applied on cancel...

Copy link

@Tranberry Tranberry commented Jan 31, 2017

how big is that canvas?

Copy link

@dacap dacap commented Jan 31, 2017

I'll try to improve the performance of filters (including Replace Color) for the next version.

@dacap dacap self-assigned this Jan 31, 2017
@dacap dacap added the feature label Jan 31, 2017
@dacap dacap added this to the v1.2 milestone Jan 31, 2017
Copy link

@oliver-ruehl oliver-ruehl commented Apr 18, 2017

Amazing work. Aseprite is now killer on Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

5 participants