Replace Color dialog preview is crazy slow #1400

Closed
oxysoft opened this Issue Jan 29, 2017 · 4 comments

Comments

Projects
None yet
5 participants

oxysoft commented Jan 29, 2017

The preview when changing to another color in the Replace Color dialog is mind bogglingly slow compared to the fill bucket for example, which is almost instant. See for yourself in this webm

https://gfycat.com/DeficientFelineCowbird

Aseprite and System version

  • Aseprite version: v1.1.11-trial
  • System: Windows 10

KasumiArai commented Jan 30, 2017 edited

Probably because the fill bucket is destructive and that preview is non destructive. i.e. using that preview won't eliminate your redo buffer, but using the fill bucket will.

It's doing it line by line in the preview so as not to use a lot of memory while not actually changing the image itself. If you hit OK (or pressed enter), the preview generation would be interrupted and the change would be instant (or at least not very slow) just like the fill tool because OK commits to an actual change rather than a preview of one.

Shorter: You'd basically need two copies of the image in memory to non destructively preview at the same speed. Or I guess a second undo stack which could be applied on cancel...

how big is that canvas?

Owner

dacap commented Jan 31, 2017

I'll try to improve the performance of filters (including Replace Color) for the next version.

dacap self-assigned this Jan 31, 2017

dacap added the enhancement label Jan 31, 2017

dacap added this to the v1.2 milestone Jan 31, 2017

dacap closed this in f381cb9 Jan 31, 2017

Amazing work. Aseprite is now killer on Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment