Replace Color dialog preview is crazy slow

[oxysoft]

The preview when changing to another color in the Replace Color dialog is mind bogglingly slow compared to the fill bucket for example, which is almost instant. See for yourself in this webm

https://gfycat.com/DeficientFelineCowbird

Aseprite and System version

• Aseprite version: v1.1.11-trial
• System: Windows 10

[KasumiArai]

Probably because the fill bucket is destructive and that preview is non destructive. i.e. using that preview won't eliminate your redo buffer, but using the fill bucket will.

It's doing it line by line in the preview so as not to use a lot of memory while not actually changing the image itself. If you hit OK (or pressed enter), the preview generation would be interrupted and the change would be instant (or at least not very slow) just like the fill tool because OK commits to an actual change rather than a preview of one.

Shorter: You'd basically need two copies of the image in memory to non destructively preview at the same speed. Or I guess a second undo stack which could be applied on cancel...

[Tranberry]

how big is that canvas?

[dacap]

I'll try to improve the performance of filters (including Replace Color) for the next version.

[oliver-ruehl]

Amazing work. Aseprite is now killer on Mac.