Paste Location Altered When Copy Location Off Canvas #1447

Closed
SolarLune opened this Issue Apr 4, 2017 · 10 comments

Comments

Projects

Done in Next release

3 participants

SolarLune commented Apr 4, 2017 edited by dacap

When you copy and paste, the pasted item appears where you copied it, but if the item is off-canvas when you copy, the paste location becomes the center of the canvas (which can be disorienting if you were just expecting it to copy anyway, or copy just the portion of the sprite that's visible on the canvas).

Aseprite and System version

Aseprite version: 1.2-beta7, Steam
System: Linux, Solus OS, 2017.1.1.0, 64-bit

SolarLune changed the title from Copy + Paste Location Inconsistent to Paste Location Altered When Copy Location Off Canvas Apr 4, 2017

dacap added the bug label May 31, 2017

dacap added this to the v1.2 milestone May 31, 2017

Owner

dacap commented May 31, 2017

Actually that is an expected behavior 🤔 If the center of the copied area is outside the canvas, when we paste it will be pasted in the center of the canvas instead of the original position (just to show to the user some feedback that the paste operation worked)

Hmm, still feels like a bug to me, as it's disorienting (to me, anyway) to have the copied sprite suddenly move to the center of the image / view. The user should know where the copy happened because they initiated it. I don't think there's a need to change the copy and paste location of an image just because it's off canvas.

Owner

dacap commented May 31, 2017

I don't think there's a need to change the copy and paste location of an image just because it's off canvas.

The problem here is that if we don't paste the clipboard content in the center of the editor's viewport, the user might never notice that he/she paste something (and that might be a problem for pixels with 0 < alpha < 255).

I'm not sure that pasting content outside the viewport would be a nice solution because the user would lost any kind of feedback about the Ctrl+V operation.

The pasted item has the floating box surrounding it, though - that shows that they pasted something. If you wanted to, you could just add an additional indicator that shows that something was pasted.

Owner

dacap commented May 31, 2017 edited

I'll show you my case with a gif where the original copied area is not visible anymore:

original-position-is-not-visible

You copy, scroll to other area, and paste. If the clipboard is pasted in the original position it would not be visible to the user.

SolarLune commented Jun 1, 2017 edited

OK, that makes sense - I'm talking about copying something that's off canvas, not off-screen. Here's an example of what I'm talking about:

peek 2017-06-01 14-41

Notice after each paste that the copied area moves back to the canvas. That's a bit disorienting if you want to do something across multiple frames (like scroll a sprite across the canvas in an animation).

Owner

dacap commented Jun 1, 2017

Oh ok! I'll take a look at this issue soon.

KasumiArai commented Jun 23, 2017 edited

Maybe only slightly related, but it'd be cool to keep at least one axis if off screen (if possible) as well. Here's a case where that would have been nice:
pastekeepaxis

dacap self-assigned this Jun 23, 2017

dacap closed this in 19f6dcf Jun 23, 2017

dacap added to Done in Next release Jun 23, 2017

Owner

dacap commented Jun 23, 2017

Both fixes will be available in the next release.

Owner

dacap commented Jun 28, 2017

This fix introduced a regression. Please read this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment