New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several issues with shift+number shortcuts #1604

Closed
andyhall opened this Issue Nov 7, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@andyhall

andyhall commented Nov 7, 2017

Hi, I noticed several issues with the default "Shift + [1..4]" shortcuts for setting layer opacity. The details vary between Windows and OSX (both current versions). This is with keyboard shortcuts set to the defaults.

  • On Mac only: the default "Shift+2" shortcut doesn't work at all. If I open the keyboard shortcuts UI and manually remove/recreate it, then it subsequently works (but shows up in the UI as Shift+@ rather than Shift+2.

  • On both Mac and Win: all "Shift + 1..4" shortcuts behave strangely when the currently selected tool has an alternate shift behavior (e.g. the brush tool, after having made an edit, so that the shift key enables line drawing). The odd behavior happens only if you press more than one shortcut without releasing the shift key.

To reproduce the latter issue:

  1. New file, select brush tool, and draw something so that shift-drawing lines is enabled
  2. Press and hold Shift (a shift-line appears)
  3. Press and release 3 (layer opacity changes, the shift-line disappears)
  4. Press and release 4 (layer opacity doesn't change, shift-line reappears)
  5. Press and release 4 (layer opacity changes, the shift-line disappears)

And so on. This only happens when the shift key is held down through multiple shortcuts - if you release shift between each shortcut things work normally (except for Shift+2 on Mac).

Thanks and regards!

Version:

  • current via Steam beta channel (v1.2.3)

@dacap dacap added bug ui native labels Nov 7, 2017

@dacap dacap self-assigned this Dec 6, 2017

@dacap dacap added this to the v1.2 milestone Dec 6, 2017

dacap added a commit that referenced this issue Dec 6, 2017

@dacap dacap closed this in 9378379 Dec 6, 2017

@dacap

This comment has been minimized.

Show comment
Hide comment
@dacap

dacap Dec 6, 2017

Member

Both fixes to be released on v1.2.5

Member

dacap commented Dec 6, 2017

Both fixes to be released on v1.2.5

@andyhall

This comment has been minimized.

Show comment
Hide comment
@andyhall

andyhall Dec 10, 2017

Hi, I confirmed the the second bug mentioned - thanks for the fix!

The first one - "Shift + 2" shortcut not working on OSX - is unchanged for me.

Since it's separate from the issue that was fixed I'll re-file it separately. No idea why I filed two different bugs in the same issue in the first place - apologies for that.

andyhall commented Dec 10, 2017

Hi, I confirmed the the second bug mentioned - thanks for the fix!

The first one - "Shift + 2" shortcut not working on OSX - is unchanged for me.

Since it's separate from the issue that was fixed I'll re-file it separately. No idea why I filed two different bugs in the same issue in the first place - apologies for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment