New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+A does not re-enable Selection Edges #1614

Closed
KashouC opened this Issue Nov 15, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@KashouC

KashouC commented Nov 15, 2017

As the title says, select all doesn't re-enable Selection Edges in View -> Show if it's turned off. Not really a big deal since, well, it selects all, but it leaves you a bit confused to if the program reacted to your input or not.

Sometimes I would prefer this functionality however, as selecting large amounts of individual pixels with the wand for example makes the program chug down to a crawl. (But remarkably it doesn't crash even after the program goes black for 6 seconds while loading.)

Aseprite v1.2.4-x64
Windows 7 x64

@dacap

This comment has been minimized.

Member

dacap commented Nov 15, 2017

Hi @KashouC, actually, there is no selection command that re-enable the View > Show > Selection Edges option automatically.

This brings several issues:

  1. The edge boundaries generation is slow/locks the UI when the selection is too irregular (this might be fixed calculating the boundaries in a background thread, long time ago I tried to do this, but never finish the implementation)
  2. If the resulting edges are too irregular, it will be too visually noisy to work with (this might be a case for a new option to show the selection only when it is simple enough, e.g. one or two rectangles)
  3. I was just testing and found a crash selecting with the magic wand and using an undo limit of 1MB (the crash happens when the undo history is too big and we have to start deleting old undo states).

So several things to be fixed.

@dacap dacap added the bug label Nov 15, 2017

@dacap dacap self-assigned this Nov 15, 2017

@dacap dacap added this to the v1.2 milestone Nov 15, 2017

@KashouC

This comment has been minimized.

KashouC commented Nov 15, 2017

That's odd. Everything I do selection wise except Ctrl+A re-enables Selection Edges.

https://www.youtube.com/watch?v=wIvvpdcNggw

Made a video to show what I mean just so we are on the same page.

@dacap

This comment has been minimized.

Member

dacap commented Nov 16, 2017

Thanks for that video! My mistake here. It looks like I tried to replicate the Photoshop behavior, and now I'm not sure if that should work in that way 😅

Let's make Ctrl+A re-enable the selection as you said originally. And maybe a new option to disable this "show selection edges automatically".

@KashouC

This comment has been minimized.

KashouC commented Nov 16, 2017

Showing is easier than describing, especially when English is a second language for both of us. ^^

Yeah, I think that is the best solution.

Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Apr 13, 2018

dacap added a commit that referenced this issue Apr 13, 2018

Merge pull request #1707 from Gasparoken/fix-selection-edges
Fix: Automatic Show Selection Edges with Cmd+A (#1614)

@dacap dacap closed this in dd82f6b Apr 20, 2018

dacap added a commit that referenced this issue Apr 20, 2018

Merge pull request #1710 from Gasparoken/auto-show-selection-edges
Add option to disable auto show selection edges (fix #1614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment