Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom brushes + Pen + Shading Ink breaks pattern alignment #1615

Closed
KashouC opened this issue Nov 15, 2017 · 2 comments
Closed

Custom brushes + Pen + Shading Ink breaks pattern alignment #1615

KashouC opened this issue Nov 15, 2017 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@KashouC
Copy link

@KashouC KashouC commented Nov 15, 2017

If you create a pattern you can draw with it as a pattern (repeating properly) unless you select the shading ink, which causes the pattern to behave like Paint Brush mode in both "Aligned to Source" and "Aligned to Destination" modes.

Aseprite 1.2.4-x64
Windows 7 x64

@dacap dacap added the bug label Jul 24, 2018
@dacap dacap added this to the v1.2 milestone Jul 24, 2018
@dacap dacap modified the milestones: v1.2, v1.x-bugs Dec 11, 2018
@dacap dacap mentioned this issue Feb 20, 2019
2 of 5 tasks complete
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Oct 9, 2019
…seprite#1615)

Additionally, to avoid code repetition, we reuse ShadingInkProceessing functions to process the new added BrushShadingInkProcessing. To accomplish it, we did nest a code portion from original ShadingInkProcess::processPixel. This codee portion was named: shadingProcessPixel(…)
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Oct 10, 2019
…seprite#1615)

Add specialization of shadingProcessPixel for each ImageTraits.
Additionally, to avoid code repetition, we reuse ShadingInkProceessing functions to process the new added BrushShadingInkProcessing. To accomplish it, we did nest a code portion from original ShadingInkProcess::processPixel. This codee portion was named: shadingProcessPixel(…)
@dacap dacap closed this in 7160f45 Oct 15, 2019
@KashouC

This comment has been minimized.

Copy link
Author

@KashouC KashouC commented Oct 15, 2019

Thank you! This fix is a big deal.

@dacap

This comment has been minimized.

Copy link
Member

@dacap dacap commented Oct 15, 2019

Thanks to @Gasparoken ❤️ 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.