Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken ellipse sizes #1649

Closed
KashouC opened this issue Jan 14, 2018 · 3 comments
Closed

Broken ellipse sizes #1649

KashouC opened this issue Jan 14, 2018 · 3 comments
Assignees
Milestone

Comments

@KashouC
Copy link

@KashouC KashouC commented Jan 14, 2018

The ellipse tool produces broken circles at very specific sizes. A 118x17 circle is not fully enclosed and missing pixels at the edges.

Aseprite v1.2.6-x64
Windows 7 x64

@Chaduke
Copy link

@Chaduke Chaduke commented Jan 15, 2018

Confirmed it occurs at 115 x 18 thru 126 x 18

@dacap dacap self-assigned this Jan 30, 2018
@dacap dacap added this to the v1.2 milestone Jan 30, 2018
@yuxshao
Copy link
Contributor

@yuxshao yuxshao commented Feb 15, 2018

@dacap If you haven't already started working on this, I'd be interested in trying to tackle this!

I'm guessing this would involve:

  • changing algo_ellipse so that somehow it steps through the outline the entire way, rather than two paths that start at the x and y poles and try meet half-way
  • if after the change algo_ellipse shapes differ:
    • update algo_ellipsefill to match the shape.
    • (also showing some proof that the new shapes aren't ridiculous? i.e. still look fine, don't have holes, and don't try to draw in a pixel more than once)
@dacap
Copy link
Member

@dacap dacap commented Feb 15, 2018

@yuxshao I've been working in a new algorithm but never finished it. I'll try your PR in these days, it looks good for me (maybe in a future I'll replace all algorithms, but that's a long term solution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants