New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successive undo-ing has become sluggish #1695

Closed
KashouC opened this Issue Mar 27, 2018 · 9 comments

Comments

Projects
None yet
2 participants
@KashouC

KashouC commented Mar 27, 2018

I've seen people mention Aseprite being slow on other operating systems, but I've never noticed it until now on Windows. Recently I've started noticing that the undo function has become very slow when holding down Ctrl+Z to undo multiple actions. Maybe this is an intentional change, maybe not, but it's still a new thing.

It's still not THAT slow, but it's a noticeable difference from 1.2.6.

Windows 7 x64
Aseprite v1.2.7.3-x64

@dacap

This comment has been minimized.

Member

dacap commented Mar 27, 2018

Hi @KashouC, no intentional change on this. I'll take a look.

@dacap

This comment has been minimized.

Member

dacap commented Mar 27, 2018

Just in case, are there some special cases where the undo is slower? e.g. undoing changes in the timeline (new frames/delete frames/layers, etc.) or the canvas, etc.

@KashouC

This comment has been minimized.

KashouC commented Mar 27, 2018

No, if I just make a new file in both 1.2.6 and in 1.2.7.3 and draw a bunch of lines with the pen, it's definitely slower in 1.2.7.3.

But like I said, it's not THAT much slower, but in bigger files I think it starts showing even more. The reason I'm making an issue out of it is that I thought that there's a chance it might be related to the other performance related issues, or just to nip it in the bud in case the issue snowballs for future versions.

@KashouC

This comment has been minimized.

KashouC commented Mar 28, 2018

Actually this isn't version related at all, but the speed of undoing is related to how big the palette side panel is. If you make it bigger the re-draw or whatever takes much longer, making it sluggish.

@dacap

This comment has been minimized.

Member

dacap commented Mar 28, 2018

I guess it's related to the "color selector" area (and worse if it's a color wheel):

screen shot 2018-03-28 at 12 16 16

@dacap dacap self-assigned this Mar 28, 2018

@dacap dacap added this to the v1.2 milestone Mar 28, 2018

@KashouC

This comment has been minimized.

KashouC commented Mar 28, 2018

Oh wow, yeah, changing from the color wheel to the color spectrum was a huuuge boost in speed.

@dacap

This comment has been minimized.

Member

dacap commented Mar 29, 2018

I'm going to fix this implementing the idea of this issue #1516

@dacap dacap closed this in 0fe5edb Mar 29, 2018

@dacap

This comment has been minimized.

Member

dacap commented Apr 4, 2018

@KashouC please check the v1.2.8 version, the color wheel shouldn't be an issue now on undo/redo

@KashouC

This comment has been minimized.

KashouC commented Apr 4, 2018

Yup, fast as lightning now! Good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment