Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes about Timeline appearance and changes in b.1.2.9. #1744

Open
oceanhahn opened this Issue Jun 5, 2018 · 10 comments

Comments

Projects
None yet
2 participants
@oceanhahn
Copy link

oceanhahn commented Jun 5, 2018

  • Having the relevant cels (current frame and layer intersections) in a new, darker colour on the Timeline is a great improvement, but losing the lighter-shade row and column backgrounds for irrelevant cels on selected layers and frames is a bit disconcerting. Is there a way to keep the unincluded cels on selected layers and frames at the second-dimmer colour? Perhaps this is intended and the current appearance is a bug.

  • Duplicating frames by CTRL-LMB-dragging them in the Timeline causes irrelevant cels in the new (duplicate) frames to be lit using the dimmer of the two Timeline selection colours; deselects all but one layer. This only happens for frames; irrelevant cels in the remaining selected layer are not dimmed.
    1 2 9timeline

  • CTRL- and SHIFT-LMB both select frames from the Timeline, but only SHIFT-LMB selects layers. CTRL-LMB probably ought to select layers as well.

  • It is not possible to select frames on the Timeline within a preexisting range. For instance, if frames 3 and 10 are selected, CTRL- or SHIFT-LMB on intervening frames (4~9) does not select those frames. It would be nice if the frame number under the cursor could be added or removed from the current selection when the cursor is not CTRL- or SHIFT-clicked, but not dragged (dragging duplicates frames as normal). It would be nice if we could deselect frames and layers this way as well.
    (This issue exists in v1.2.8 as well.)

  • When multiple layers are selected, it would be handy if the various layer options (lock, show/hide, link new frames..) for all selected layers could be toggled with a single click, perhaps using the icon at the top of the layers list or by holding SHIFT or CTRL.

  • As a thought, when multiple selected frames or layers are moved, perhaps they ought to maintain their spacing relative to one another, rather than piling up at the end of the new location? It is a bit hard to predict how frames and layers move this way. It may be difficult to work out how these frame moves will interact with frame tags.
    (This was also an issue for frames in v1.2.8.)

Related to comments in #1741.
..using ASEprite beta.1.2.9 (Steam) on Win10.

(Sorry I could not think of a better way of presenting these. 😕)

@dacap dacap self-assigned this Jun 6, 2018

@dacap dacap added this to the v1.2 milestone Jun 6, 2018

@dacap

This comment has been minimized.

Copy link
Member

dacap commented Jun 6, 2018

Is there a way to keep the unincluded cels on selected layers and frames at the second-dimmer colour? Perhaps this is intended and the current appearance is a bug.

I've changed the look on purpose. But I don't like it. We might need another color, but not sure yet (I have to give another try).

Duplicating frames by CTRL-LMB-dragging them in the Timeline causes irrelevant cels in the new (duplicate) frames to be lit using the dimmer of the two Timeline selection colours; deselects all but one layer

+1 Something to be fixed.

CTRL- and SHIFT-LMB both select frames from the Timeline, but only SHIFT-LMB selects layers. CTRL-LMB probably ought to select layers as well.

Not yet sure, I think Ctrl+click should start copying. So maybe shift+click should be the only way to increment selection (just like the rectangular marquee works on the canvas).

It is not possible to select frames on the Timeline within a preexisting range. For instance, if frames 3 and 10 are selected, CTRL- or SHIFT-LMB on intervening frames (4~9) does not select those frames.

Actually I'm testing on Linux and I can click in frames inside the preexisting range with Shift+left mouse button. (Ctrl+click doesn't work, but Shift+click does work.)

When multiple layers are selected, it would be handy if the various layer options (lock, show/hide, link new frames..) for all selected layers could be toggled with a single click, perhaps using the icon at the top of the layers list or by holding SHIFT or CTRL.

I've to check if this is already working on an internal v1.3-beta branch I have. But if the idea is not already included for a future beta, it might be implemented anyway as you said.

As a thought, when multiple selected frames or layers are moved, perhaps they ought to maintain their spacing relative to one another, rather than piling up at the end of the new location? It is a bit hard to predict how frames and layers move this way.

I think this should be solved with the possibility to select/move different range of cels #1510. In v1.2.9 this is not possible, we can select multiple cels shift+clicking layers and frames, but not cels. So moving frames should behave as it behaves (moves everything to the same location), but moving cels should move everything as a fixed block.

It may be difficult to work out how these frame moves will interact with frame tags

Related to #1656

@oceanhahn

This comment has been minimized.

Copy link
Author

oceanhahn commented Jun 6, 2018

Not yet sure, I think Ctrl+click should start copying. So maybe shift+click should be the only way to increment selection (just like the rectangular marquee works on the canvas).

Are we making a distinction between CTRL-LMB-Drag and CTRL-LMB here, or are they handled the same way? (Non-CTRL) LMB-drag behaves differently from LMB-click (kind of), so I had assumed that they were different enough that it would be all right for them to do different things in this way. I am totally prepared to be wrong, though!

Actually I'm testing on Linux and I can click in frames inside the preexisting range with Shift+left mouse button. (Ctrl+click doesn't work, but Shift+click does work.)

Rechecked. SHIFT-LMB does work. My bad; I probably got the whole CTRL- vs. CHIFT-LMB-layer selection thing mixed up in my thoughts. x_x

Thanks for the speedy response!

@dacap

This comment has been minimized.

Copy link
Member

dacap commented Jun 6, 2018

Are we making a distinction between CTRL-LMB-Drag and CTRL-LMB here, or are they handled the same way?

🤔 I guess that we can make a distintion, but it will complicate a little the code, so low priority at the moment.

Ctrl+click doesn't work, but Shift+click does work.
Rechecked. SHIFT-LMB does work.

👍

@dacap

This comment has been minimized.

Copy link
Member

dacap commented Jun 6, 2018

losing the lighter-shade row and column backgrounds for irrelevant cels on selected layers and frames is a bit disconcerting

I didn't find a good way to fix this. With an extra color shade it's too confusing (too many shades). Maybe the timeline could have the same look as 1.2.8 when there isn't a selection of multiple frames, and be like 1.2.9 when there are multiple layers/frames.

@oceanhahn

This comment has been minimized.

Copy link
Author

oceanhahn commented Jun 6, 2018

I didn't find a good way to fix this. With an extra color shade it's too confusing (too many shades).

I suppose what I am imagining is something like this:
image

The red cel being the intersection of the current frame and active layer.
(It does not have to be red. XD )

Or even throwing that yellow outline around relevant frames. I feel like that might get too busy after a while, but it would be very clear which frames were and were not included and would not require an expanded colour table for the Timeline.
Not exactly, anyway.. <_<;

@dacap

This comment has been minimized.

Copy link
Member

dacap commented Jun 6, 2018

I suppose what I am imagining is something like this

Yeah, I did something like that. There are too many shades, anyway I don't like the 1.2.9-beta1 look, the final result might be something similar to your screenshot.

@oceanhahn

This comment has been minimized.

Copy link
Author

oceanhahn commented Jun 6, 2018

I have this other mockup, if you are interested in that look.
I do not like this version as much as the first, I think, for reason that it adds even more colours to something you feel is too varied already. But here it is anyway, for your consideration:
image
I am not 100% on this colour scheme but you get the idea. ^^;

@dacap

This comment has been minimized.

Copy link
Member

dacap commented Jun 7, 2018

Fixing this:

Duplicating frames by CTRL-LMB-dragging them in the Timeline causes irrelevant cels in the new (duplicate) frames to be lit using the dimmer of the two Timeline selection colours

Bring the following issue too:

when multiple selected frames or layers are moved, perhaps they ought to maintain their spacing relative to one another, rather than piling up at the end of the new location? It is a bit hard to predict how frames and layers move this way.

I guess that moving/copying multiple frames + layers will act like moving/copying a block.

@oceanhahn

This comment has been minimized.

Copy link
Author

oceanhahn commented Jun 7, 2018

I have updated the top post in this thread to include a checklist, if that makes things easier for you.
I do not know what you define as "complete," so the boxes have been left unchecked.
If you do not want to curate it, I can do it as changes are moved to the beta or main branches. 😃

dacap added a commit that referenced this issue Jun 8, 2018

Bring back the old timeline style (#1741, #1744)
We've added a new shade to show the focused cel (active layer/frame)
inside the selected range of the timeline when multiple cels are
selected.
@dacap

This comment has been minimized.

Copy link
Member

dacap commented Jun 8, 2018

I've updated the Steam beta branch with some changes about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.