New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color palette does not scroll #1796

Closed
chongx1an opened this Issue Jul 23, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@chongx1an

chongx1an commented Jul 23, 2018

The color palette does not scroll while moving the color toward up or down.

aspritebug

Aseprite and System version

  • Aseprite version: v1.3-dev
  • System: Windows 10
@dacap

This comment has been minimized.

Show comment
Hide comment
@dacap

dacap Jul 23, 2018

Member

Related to #772, some scroll issues to solve

Member

dacap commented Jul 23, 2018

Related to #772, some scroll issues to solve

@chongx1an

This comment has been minimized.

Show comment
Hide comment
@chongx1an

chongx1an commented Jul 24, 2018

Thx

@dacap dacap added this to the v1.2 milestone Jul 24, 2018

@dacap dacap added the bug label Jul 24, 2018

@dacap dacap assigned dacap and Gasparoken and unassigned dacap Jul 24, 2018

@Vcoder89

This comment has been minimized.

Show comment
Hide comment
@Vcoder89

Vcoder89 Jul 25, 2018

Working on a fix.

Vcoder89 commented Jul 25, 2018

Working on a fix.

Vcoder89 pushed a commit to Vcoder89/aseprite that referenced this issue Jul 25, 2018

vcoder
Selection of a range in color pallet now scrolls.
Fixes aseprite#1796
Simply added an update_scroll call after the mouse dragging is processed.

Vcoder89 pushed a commit to Vcoder89/aseprite that referenced this issue Jul 25, 2018

vcoder
Selection of a range in color pallet now scrolls.
Fixes aseprite#1796
Simply added an update_scroll call after the mouse dragging is processed.

Left stdio to trace by mistake.

Vcoder89 pushed a commit to Vcoder89/aseprite that referenced this issue Jul 25, 2018

vcoder
Selection of a range in color pallet now scrolls.
Fixes aseprite#1796
Simply added an update_scroll call after the mouse dragging is processed.
@chongx1an

This comment has been minimized.

Show comment
Hide comment
@chongx1an

chongx1an Jul 26, 2018

One question:
The "palette entry" refers to the first color in the palette?

chongx1an commented Jul 26, 2018

One question:
The "palette entry" refers to the first color in the palette?

@Vcoder89

This comment has been minimized.

Show comment
Hide comment
@Vcoder89

Vcoder89 Jul 26, 2018

My change doesn't affect anything named "palette entry" so I'm assuming you're talking about "dragPicks.firstPick()" which the name itself should help out, it's purely the first slot you pick from the drag & drop action, so if you selected 7 and start dragging them around, it will use the first one you clicked on to correctly pan the scroll. Hope this helps. I'm still working on this based on dacap's review.

Vcoder89 commented Jul 26, 2018

My change doesn't affect anything named "palette entry" so I'm assuming you're talking about "dragPicks.firstPick()" which the name itself should help out, it's purely the first slot you pick from the drag & drop action, so if you selected 7 and start dragging them around, it will use the first one you clicked on to correctly pan the scroll. Hope this helps. I'm still working on this based on dacap's review.

@chongx1an

This comment has been minimized.

Show comment
Hide comment
@chongx1an

chongx1an Jul 27, 2018

Ok, thanks for your answer

chongx1an commented Jul 27, 2018

Ok, thanks for your answer

Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jul 27, 2018

@dacap dacap closed this in 5e86884 Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment