Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim by grid #1926

Closed
dacap opened this issue Nov 12, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@dacap
Copy link
Member

commented Nov 12, 2018

The trim option on Export Sprite Sheet or the CLI could include an alternative behavior to trim by grid tile instead of by pixel (so only if a grid tile is completely empty, we trim it out).


Implementation details: DocExporter::captureSamples() creates the samples for the sprite sheet, if trim option is enabled the algorithm::shrink_bounds function is used to trim the bounds of the sampleRender image. With this new option we should use an alternative algorithm that shrink by tile grids instead of by pixel (some possible problems: getting the grid settings of the sample document).

@dacap dacap added this to the v1.2 milestone Nov 12, 2018

@dacap dacap modified the milestones: v1.2, v1.3 Dec 11, 2018

@dacap dacap modified the milestones: v1.3, v1.2 Dec 28, 2018

dncampo added a commit to dncampo/aseprite that referenced this issue Feb 5, 2019

@dncampo dncampo referenced this issue Feb 5, 2019

Closed

Trim by grid #2004

dacap added a commit that referenced this issue Feb 7, 2019

Add Trim by Grid option in Export Sprite Sheet (#1926)
This adds the logic and UI part of Trim by Grid feature, the CLI part
is not yet implemented.

@dacap dacap modified the milestones: v1.3, v1.2 Feb 7, 2019

@dacap

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2019

The only missing part of this issue is exposing the behavior in the CLI with an argument like --trim-by-grid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.