Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create palette creates duplicated black color #2109

Closed
l-Marty-l opened this issue Jul 14, 2019 · 4 comments

Comments

@l-Marty-l
Copy link

commented Jul 14, 2019

Screenshot 2019-07-14 at 21 27 21

When I select "Create Palette from current Sprite", it will add black twice. Both are #000000 with Alpha 255.

Aseprite and System version

  • Aseprite version: v1.3-dev
  • System: macOS, 10.14.5
@dacap

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Do you have a transparent layer using the black color? in that case this might be because the first black color (palette entry number zero) is used as transparent color for transparent layers, and the second black color is the black color used in transparent color when a solid black pixel is needed.

@l-Marty-l

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

Do you have a transparent layer using the black color? in that case this might be because the first black color (palette entry number zero) is used as transparent color for transparent layers, and the second black color is the black color used in transparent color when a solid black pixel is needed.

My transparent layers use transparent as color, so a second black color makes no sense to me. Maybe I understand you wrong, though.

@dacap

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

I've seen the file you sent me (only transparent layers, with black color on some of the layers), and it looks like a bug, mainly because Aseprite generates the first black palette entry with alpha = 255 (100%) even when the "Create entries with alpha component" checkbox is selected.

So my conclusion is:

  1. If you use the dialog with the options given as in the screenshot, two black color entries will be generated anyway (because entries with alpha cannot be generated)
  2. If you check the "Create entries with alpha component" option, instead of two black colors you should see the first palette entry (index 0) with alpha=0 (which this is not happening, so here is the bug).

@dacap dacap added the bug label Jul 15, 2019

@dacap dacap added this to the v1.x-bugs milestone Jul 15, 2019

@dacap dacap self-assigned this Jul 15, 2019

@l-Marty-l

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

  1. If you use the dialog with the options given as in the screenshot, two black color entries will be generated anyway (because entries with alpha cannot be generated)

Ah, now it makes sense to me why I get two black colors.

  1. If you check the "Create entries with alpha component" option, instead of two black colors you should see the first palette entry (index 0) with alpha=0 (which this is not happening, so here is the bug).

Yes, I experience the same, I tried to check the check box before as well and still two black colors. Glad you can reproduce the issue.

@dacap dacap closed this in 2a42cc1 Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.