Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ellipses for 16x16 were better with the previous algorithm #2217

Closed
dacap opened this issue Dec 9, 2019 · 4 comments
Closed

Ellipses for 16x16 were better with the previous algorithm #2217

dacap opened this issue Dec 9, 2019 · 4 comments
Assignees
@Gasparoken
Labels
feature Feature request, or something should be improved
Milestone
v1.2.28

Comments

@dacap
Copy link
Member

dacap commented Dec 9, 2019 •
edited

image

The main difference of the previous algorithm is that it used the shape of the ellipse with odd radius for even radiuses (e.g. the circle 16x16 looked like the 15x15 but with an extra pixel in the axes).
@dacap dacap added the feature Feature request, or something should be improved label Dec 9, 2019
@dacap dacap added this to the v1.x-bugs milestone Dec 9, 2019
@dacap dacap self-assigned this Dec 10, 2019
@GAZ082
Copy link

GAZ082 commented Nov 30, 2020

Jesus, circles were actually lookable in older versions? Would be nice to have an option to revert to the old algorithm!

@dacap
Copy link
Member Author

dacap commented Dec 3, 2020

I tried to get them back but the old algorithm had a bug with certain ellipse sizes that crashes the program (or create an infinite loop), so I'll try to fix the current algorithm to create the older look in someway. It's top priority but it would be nice to have in the final v1.2.26.

@dacap dacap assigned Gasparoken and unassigned dacap Feb 4, 2021
@GAZ082
Copy link

GAZ082 commented May 23, 2021

Hey @dacap David, how is the dev going for this? Cheers.

@dacap
Copy link
Member Author

dacap commented May 24, 2021

Hi @GAZ082, we'll see if we can finish this change for the 2nd v1.3 beta (v1.3-beta2).

Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 11, 2021
@Gasparoken
Fix ellipses for 16x16 were better with the previous algorithm (fix a…
14da89f 
…seprite#2217)

Also, 'ellipse_algo ()' function supports using additional straight pixels to allow the algorithm to be able to draw rounded squares
@dacap dacap closed this as completed in 1eace24 Jun 11, 2021
@dacap dacap modified the milestones: v1.x-bugs, v1.2.28 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gasparoken Gasparoken

Labels
feature Feature request, or something should be improved
Projects
None yet
Milestone
v1.2.28
Development

No branches or pull requests
3 participants
@dacap @GAZ082 @Gasparoken